From 24d968384b08b51cf1163708939f198f23d6a809 Mon Sep 17 00:00:00 2001
From: Neil Hanlon <neil@shrug.pw>
Date: Thu, 12 Sep 2024 12:59:03 -0400
Subject: [PATCH] address review comments

---
 changelog    | 23 +++++++++++++++++++++++
 tinyows.spec | 43 +++++++------------------------------------
 2 files changed, 30 insertions(+), 36 deletions(-)
 create mode 100644 changelog

diff --git a/changelog b/changelog
new file mode 100644
index 0000000..04b0362
--- /dev/null
+++ b/changelog
@@ -0,0 +1,23 @@
+* Tue Aug 20 2024 Neil Hanlon <neil@shrug.pw> - 1.2.2-1
+- update to 1.2.2 for re-review
+
+* Mon Jun 07 2010 Balint Cristian <cristian.balint@gmail.com> - 0.8.0-1
+- new upstream
+
+* Thu Mar 18 2010 Balint Cristian <rezso@rdsor.ro> - 0.7.0-1
+- new upstream
+
+* Sun Jul 26 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.6.0-5
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
+
+* Wed Feb 25 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.6.0-4
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
+
+* Mon Jan 05 2009 Balint Cristian <rezso@rdsor.ro> - 0.6.0-3
+- initial import
+
+* Thu Sep 25 2008 Balint Cristian <rezso@rdsor.ro> - 0.6.0-2
+- shorter summary description
+
+* Thu Sep 25 2008 Balint Cristian <rezso@rdsor.ro> - 0.6.0-1
+- initial package for fedora 
diff --git a/tinyows.spec b/tinyows.spec
index 3bd9b2d..059c354 100644
--- a/tinyows.spec
+++ b/tinyows.spec
@@ -3,7 +3,7 @@
 
 Name:      tinyows
 Version:   1.2.2
-Release:   1%{?dist}
+Release:   %autorelease
 Summary:   WFS-T and FE implementation server
 
 License:   MIT
@@ -61,7 +61,7 @@ sed -i -e 's|/usr/tinyows/|%{_datadir}/%{name}/|' src/ows_define.h
 # fix DSO lookup
 sed -i -e 's|-lpq|-lpq -lm|' Makefile
 
-make %{?_smp_mflags}
+%make_build
 
 # disable timestamp inside docs
 sed -i -e 's|HTML_FOOTER|HTML_FOOTER=no_date_footer.html\n\#|g' doc/Doxyfile
@@ -70,28 +70,22 @@ make doxygen
 %install
 
 install -d %{buildroot}%{_bindir}
-cp %{_bindir}/shp2pgsql %{buildroot}%{_bindir}/shp2pgsql
 install -p -m 0755 tinyows %{buildroot}%{_bindir}/
 install -d %{buildroot}%{_datadir}/%{name}
 cp -pR schema %{buildroot}%{_datadir}/%{name}/
 install -d %{buildroot}%{_sysconfdir}/%{name}
 install -p -m 0644 ms4w/apps/tinyows-svn/config.xml %{buildroot}%{_sysconfdir}/%{name}
-pushd %{buildroot}%{_datadir}/%{name}/
-   ln -s ../../../%{_sysconfdir}/%{name}/config.xml config.xml
-popd
 
-%check
+ln -s --relative %{buildroot}%{_sysconfdir}/%{name}/config.xml %{buildroot}%{_datadir}/%{name}/
 
-# NOTE(neil): 2024-08-25 tests require a postgres database running; unable to run in %check
+# NOTE(neil): 2024-08-25 tests require a postgres database running; unable to run in check
 # https://github.com/MapServer/tinyows/blob/f1dc7bc86fc4d69faddd79ed2804d98c11802ba8/.github/workflows/linux.sh#L19-L22
-# make check || true
+%dnl %check
 
 %files
-%defattr(-,root,root,-)
-%license LICENSE.md
+%license LICENSE.md schema/LICENSE
 %doc README.md VERSION.md
 %doc doc/doxygen
-%{_bindir}/shp2pgsql
 %{_bindir}/%{name}
 %dir %{_sysconfdir}/%{name}
 %attr(644,root,root) %config(noreplace) %{_sysconfdir}/%{name}/config.xml
@@ -99,27 +93,4 @@ popd
 %files doc
 %{_datadir}/%{name}
 
-%changelog
-* Tue Aug 20 2024 Neil Hanlon <neil@shrug.pw> - 1.2.2-1
-- update to 1.2.2 for re-review
-
-* Mon Jun 07 2010 Balint Cristian <cristian.balint@gmail.com> - 0.8.0-1
-- new upstream
-
-* Thu Mar 18 2010 Balint Cristian <rezso@rdsor.ro> - 0.7.0-1
-- new upstream
-
-* Sun Jul 26 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.6.0-5
-- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
-
-* Wed Feb 25 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.6.0-4
-- Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
-
-* Mon Jan 05 2009 Balint Cristian <rezso@rdsor.ro> - 0.6.0-3
-- initial import
-
-* Thu Sep 25 2008 Balint Cristian <rezso@rdsor.ro> - 0.6.0-2
-- shorter summary description
-
-* Thu Sep 25 2008 Balint Cristian <rezso@rdsor.ro> - 0.6.0-1
-- initial package for fedora 
+%autochangelog