From ef7830662e78043705178fdfe4449f9486af4c62 Mon Sep 17 00:00:00 2001
From: Zef Hemel <zef@zef.me>
Date: Mon, 16 Jan 2023 10:40:16 +0100
Subject: [PATCH] Support syscalls in sandboxed iframes

---
 plugs/core/core.plug.yaml |   4 +-
 plugs/core/debug.ts       | 125 ++++++++++----------------------------
 web/components/panel.tsx  |  61 ++++++++++++++++++-
 web/editor.tsx            |   4 +-
 web/index.html            |   1 -
 web/styles/main.scss      |   1 +
 web/styles/theme.scss     |   2 +
 7 files changed, 98 insertions(+), 100 deletions(-)

diff --git a/plugs/core/core.plug.yaml b/plugs/core/core.plug.yaml
index 617d147..574ab5c 100644
--- a/plugs/core/core.plug.yaml
+++ b/plugs/core/core.plug.yaml
@@ -374,11 +374,9 @@ functions:
   showLogsCommand:
     path: ./debug.ts:showLogsCommand
     command:
-      name: "Debug: Show Logs"
+      name: "Show Logs"
       key: "Ctrl-Alt-l"
       mac: "Cmd-Alt-l"
-    events:
-      - log:reload
   hideBhsCommand:
     path: ./debug.ts:hideBhsCommand
     command:
diff --git a/plugs/core/debug.ts b/plugs/core/debug.ts
index 93d2eed..ccfa62c 100644
--- a/plugs/core/debug.ts
+++ b/plugs/core/debug.ts
@@ -1,10 +1,4 @@
-import { sandbox } from "$sb/plugos-syscall/mod.ts";
-import {
-  editor,
-  markdown,
-  sandbox as serverSandbox,
-  system,
-} from "$sb/silverbullet-syscall/mod.ts";
+import { editor, markdown } from "$sb/silverbullet-syscall/mod.ts";
 
 export async function parsePageCommand() {
   console.log(
@@ -18,22 +12,13 @@ export async function parsePageCommand() {
 }
 
 export async function showLogsCommand() {
-  // Running in client/server mode?
-  const clientServer = !!(await system.getEnv());
-
-  if (clientServer) {
-    const clientLogs = await sandbox.getLogs();
-    const serverLogs = await serverSandbox.getServerLogs();
-    await editor.showPanel(
-      "bhs",
-      1,
-      `
+  await editor.showPanel(
+    "bhs",
+    1,
+    `
     <style>
-    #reload {
-      width: 75%;
-    }
     #close {
-      width: 20%;
+      width: 100%;
     }
     #client-log-header {
         position: absolute;
@@ -63,87 +48,43 @@ export async function showLogsCommand() {
         overflow: scroll;
     }
     </style>
-    <button onclick="self.reloadLogs()" id="reload">Reload</button>
     <button onclick="self.close()" id="close">Close</button>
     <div id="client-log-header">Client logs (max 100)</div>
-    <div id="client-log">
-      <pre>${
-        clientLogs
-          .map((le) => `[${le.level}] ${le.message}`)
-          .join("\n")
-      }</pre>
-    </div>
+    <div id="client-log">Loading...</div>
     <div id="server-log-header">Server logs (max 100)</div>
-    <div id="server-log">
-      <pre>${
-        serverLogs
-          .map((le) => `[${le.level}] ${le.message}`)
-          .join("\n")
-      }</pre>
-    </div>`,
-      `
-      var clientDiv = document.getElementById("client-log");
+    <div id="server-log">Loading...</div>`,
+    `
+      const clientDiv = document.getElementById("client-log");
       clientDiv.scrollTop = clientDiv.scrollHeight;
-      var serverDiv = document.getElementById("server-log");
+      const serverDiv = document.getElementById("server-log");
       serverDiv.scrollTop = serverDiv.scrollHeight;
 
-      self.reloadLogs = () => {
-        sendEvent("log:reload");
-      };
       self.close = () => {
         sendEvent("log:hide");
       };
+
+      syscall("system.getEnv").then((env) => {
+        const clientServerMode = !!env;
+        if (!clientServerMode) {
+          // Running in hybrid mode (mobile), so let's ignore server logs (they're the same as client logs)
+          serverDiv.style.display = "none";
+          clientDiv.style.width = "100%";
+          document.getElementById("server-log-header").style.display = "none";
+        }
+  
+        setInterval(() => {
+          Promise.resolve().then(async () => {
+            if(clientServerMode) {
+              const serverLogs = await syscall("sandbox.getServerLogs");
+              serverDiv.innerHTML = "<pre>" + serverLogs.map((le) => "[" + le.level + "] " + le.message).join("\\n") + "</pre>";
+            }
+            const clientLogs = await syscall("sandbox.getLogs");
+            clientDiv.innerHTML = "<pre>" + clientLogs.map((le) => "[" + le.level + "] " + le.message).join("\\n") + "</pre>";
+          }).catch(console.error);
+        }, 1000);
+      });
       `,
-    );
-  } else {
-    const logs = await sandbox.getLogs();
-    await editor.showPanel(
-      "bhs",
-      1,
-      `
-        <style>
-        #reload {
-          width: 75%;
-        }
-        #close {
-          width: 20%;
-        }
-        #log-header {
-          position: absolute;
-          left: 0;
-          top: 35px;
-        }
-        #log {
-          position: absolute;
-          left: 0;
-          top: 60px;
-          bottom: 0;
-          width: 100%;
-          overflow: scroll;
-        }
-        </style>
-        <button onclick="self.reloadLogs()" id="reload">Reload</button>
-        <button onclick="self.close()" id="close">Close</button>
-            <div id="log-header">Logs (max 100)</div>
-        <div id="log">
-          <pre>${
-        logs
-          .map((le) => `[${le.level}] ${le.message}`)
-          .join("\n")
-      }</pre>
-        </div>`,
-      `
-          var clientDiv = document.getElementById("log");
-          clientDiv.scrollTop = clientDiv.scrollHeight;
-          self.reloadLogs = () => {
-            sendEvent("log:reload");
-          };
-          self.close = () => {
-            sendEvent("log:hide");
-          };
-          `,
-    );
-  }
+  );
 }
 
 export async function hideBhsCommand() {
diff --git a/web/components/panel.tsx b/web/components/panel.tsx
index bb10cce..d494e05 100644
--- a/web/components/panel.tsx
+++ b/web/components/panel.tsx
@@ -8,6 +8,22 @@ export const panelHtml = `<!DOCTYPE html>
     <meta charset="UTF-8">
     <base target="_top">
 <script>
+const pendingRequests = new Map();
+let syscallReqId = 0;
+
+self.syscall = async (name, ...args) => {
+  return await new Promise((resolve, reject) => {
+    syscallReqId++;
+    pendingRequests.set(syscallReqId, { resolve, reject });
+    window.parent.postMessage({
+      type: "syscall",
+      id: syscallReqId,
+      name,
+      args,
+    }, "*");
+  });
+};
+
 window.addEventListener("message", (message) => {
   const data = message.data;
   switch (data.type) {
@@ -20,6 +36,28 @@ window.addEventListener("message", (message) => {
           console.error("Error evaling script", e);
         }
       }
+      break;
+    case "syscall-response":
+      {
+        const syscallId = data.id;
+        const lookup = pendingRequests.get(syscallId);
+        if (!lookup) {
+          console.log(
+            "Current outstanding requests",
+            pendingRequests,
+            "looking up",
+            syscallId,
+          );
+          throw Error("Invalid request id");
+        }
+        pendingRequests.delete(syscallId);
+        if (data.error) {
+          lookup.reject(new Error(data.error));
+        } else {
+          lookup.resolve(data.result);
+        }
+      }
+
       break;
   }
 });
@@ -92,8 +130,27 @@ export function Panel({
       if (!data) {
         return;
       }
-      if (data.type === "event") {
-        editor.dispatchAppEvent(data.name, ...data.args);
+      switch (data.type) {
+        case "event":
+          editor.dispatchAppEvent(data.name, ...data.args);
+          break;
+        case "syscall": {
+          const { id, name, args } = data;
+          editor.system.localSyscall("core", name, args).then((result) => {
+            iFrameRef.current!.contentWindow!.postMessage({
+              type: "syscall-response",
+              id,
+              result,
+            });
+          }).catch((e: any) => {
+            iFrameRef.current!.contentWindow!.postMessage({
+              type: "syscall-response",
+              id,
+              error: e.message,
+            });
+          });
+          break;
+        }
       }
     };
     globalThis.addEventListener("message", messageListener);
diff --git a/web/editor.tsx b/web/editor.tsx
index 2f8f111..efe7128 100644
--- a/web/editor.tsx
+++ b/web/editor.tsx
@@ -130,8 +130,8 @@ export class Editor {
       .dispatchEvent("editor:updated")
       .catch((e) => console.error("Error dispatching editor:updated event", e));
   }, 1000);
-  private system: System<SilverBulletHooks>;
-  private mdExtensions: MDExt[] = [];
+  system: System<SilverBulletHooks>;
+  mdExtensions: MDExt[] = [];
   urlPrefix: string;
   indexPage: string;
 
diff --git a/web/index.html b/web/index.html
index 3618483..9508050 100644
--- a/web/index.html
+++ b/web/index.html
@@ -41,7 +41,6 @@
 
 <body>
   <div id="sb-root"></div>
-  <h1>SUPPP</h1>
 </body>
 
 </html>
\ No newline at end of file
diff --git a/web/styles/main.scss b/web/styles/main.scss
index 221b0d7..50206e5 100644
--- a/web/styles/main.scss
+++ b/web/styles/main.scss
@@ -139,6 +139,7 @@
 .sb-bhs {
   height: 300px;
   width: 100%;
+  z-index: 1000;
 
   .sb-panel {
     height: 100%;
diff --git a/web/styles/theme.scss b/web/styles/theme.scss
index 5aa1c6c..a5b7ad8 100644
--- a/web/styles/theme.scss
+++ b/web/styles/theme.scss
@@ -16,10 +16,12 @@
 
 .sb-panel {
   border-left: 1px solid #eee;
+  background-color: #fff;
 }
 
 .sb-bhs {
   border-top: rgb(193, 193, 193) 1px solid;
+  background-color: #fff;
 }
 
 .sb-modal {