PlugOS refactor and other tweaks (#631)

* Prep for in-process plug loading (e.g. for CF workers, Deno Deploy)
* Prototype of fixed in-process loading plugs
* Fix: buttons not to scroll with content
* Better positioning of modal especially on mobile
* Move query caching outside query
* Fix annoying mouse behavior when filter box appears
* Page navigator search tweaks

plugos/lib/datastore.test.ts

@@ -7,7 +7,7 @@ import { assertEquals } from "https://deno.land/std@0.165.0/testing/asserts.ts";
 import { PrefixedKvPrimitives } from "./prefixed_kv_primitives.ts";
 
 async function test(db: KvPrimitives) {
-  const datastore = new DataStore(new PrefixedKvPrimitives(db, ["ds"]), false, {
+  const datastore = new DataStore(new PrefixedKvPrimitives(db, ["ds"]), {
     count: (arr: any[]) => arr.length,
   });
   await datastore.set(["user", "peter"], { name: "Peter" });

plugos/lib/datastore.ts

@@ -2,18 +2,13 @@ import { applyQueryNoFilterKV, evalQueryExpression } from "$sb/lib/query.ts";
 import { FunctionMap, KV, KvKey, KvQuery } from "$sb/types.ts";
 import { builtinFunctions } from "$sb/lib/builtin_query_functions.ts";
 import { KvPrimitives } from "./kv_primitives.ts";
-import { LimitedMap } from "../../common/limited_map.ts";
-
 /**
  * This is the data store class you'll actually want to use, wrapping the primitives
  * in a more user-friendly way
  */
 export class DataStore {
-  private cache = new LimitedMap<any>(20);
-
   constructor(
     readonly kv: KvPrimitives,
-    private enableCache = false,
     private functionMap: FunctionMap = builtinFunctions,
   ) {
   }
@@ -63,21 +58,6 @@ export class DataStore {
   }
 
   async query<T = any>(query: KvQuery): Promise<KV<T>[]> {
-    let cacheKey: string | undefined;
-    const cacheSecs = query.cacheSecs;
-    // Should we do caching?
-    if (cacheSecs && this.enableCache) {
-      // Remove the cacheSecs from the query
-      query = { ...query, cacheSecs: undefined };
-      console.log("Going to cache query", query);
-      cacheKey = JSON.stringify(query);
-      const cachedResult = this.cache.get(cacheKey);
-      if (cachedResult) {
-        // Let's use the cached result
-        return cachedResult;
-      }
-    }
-
     const results: KV<T>[] = [];
     let itemCount = 0;
     // Accumulate results
@@ -104,12 +84,7 @@ export class DataStore {
       }
     }
     // Apply order by, limit, and select
-    const finalResult = applyQueryNoFilterKV(query, results, this.functionMap);
-    if (cacheKey) {
-      // Store in the cache
-      this.cache.set(cacheKey, finalResult, cacheSecs! * 1000);
-    }
-    return finalResult;
+    return applyQueryNoFilterKV(query, results, this.functionMap);
   }
 
   async queryDelete(query: KvQuery): Promise<void> {

plugos/lib/mq_util.ts

@@ -1,7 +0,0 @@
-// Adds a plug name to a queue name if it doesn't already have one.
-export function fullQueueName(plugName: string, queueName: string) {
-  if (queueName.includes(".")) {
-    return queueName;
-  }
-  return plugName + "." + queueName;
-}