1
0

Top-bottom panel refactor, more instant rendering

This commit is contained in:
Zef Hemel 2023-12-27 18:05:47 +01:00
parent 9403fd2cd9
commit 4d66f23391
16 changed files with 227 additions and 327 deletions

View File

@ -7,6 +7,7 @@ import { PlugNamespaceHookT } from "./hooks/plug_namespace.ts";
import { CodeWidgetT } from "../web/hooks/code_widget.ts";
import { MQHookT } from "../plugos/hooks/mq.ts";
import { EndpointHookT } from "../plugos/hooks/endpoint.ts";
import { PanelWidgetT } from "../web/hooks/panel_widget.ts";
/** Silverbullet hooks give plugs access to silverbullet core systems.
*
@ -22,6 +23,7 @@ export type SilverBulletHooks =
& MQHookT
& EventHookT
& CodeWidgetT
& PanelWidgetT
& EndpointHookT
& PlugNamespaceHookT;

View File

@ -80,7 +80,7 @@ export function filterBox(
}
export function showPanel(
id: "lhs" | "rhs" | "bhs" | "modal" | "bottom" | "top",
id: "lhs" | "rhs" | "bhs" | "modal",
mode: number,
html: string,
script = "",
@ -89,7 +89,7 @@ export function showPanel(
}
export function hidePanel(
id: "lhs" | "rhs" | "bhs" | "modal" | "bottom" | "top",
id: "lhs" | "rhs" | "bhs" | "modal",
): Promise<void> {
return syscall("editor.hidePanel", id);
}

View File

@ -1,19 +0,0 @@
function processClick(e) {
const dataEl = e.target.closest("[data-ref]");
syscall(
"system.invokeFunction",
"index.navigateToMention",
dataEl.getAttribute("data-ref"),
).catch(console.error);
}
document.getElementById("link-ul").addEventListener("click", processClick);
document.getElementById("hide-button").addEventListener("click", () => {
syscall("system.invokeFunction", "index.toggleMentions").catch(console.error);
});
document.getElementById("reload-button").addEventListener("click", () => {
syscall("system.invokeFunction", "index.renderMentions").catch(
console.error,
);
});

View File

@ -1,76 +0,0 @@
/* Reset SB styles */
html,
body {
/*height: initial !important;
overflow-x: initial !important;
overflow-y: hidden !important;*/
background-color: var(--root-background-color) !important;
}
#sb-main {
height: initial !important;
display: initial !important;
}
#sb-editor {
flex: initial !important;
height: initial !important;
}
.cm-editor {
height: initial !important;
}
body {
font-family: var(--ui-font);
color: var(--root-color);
}
.sb-line-h2 {
border-top-right-radius: 5px;
border-top-left-radius: 5px;
margin: 0;
padding: 10px !important;
background-color: rgba(233, 233, 233, 0.5);
}
#button-bar {
position: absolute;
right: 10px;
top: 10px;
padding: 0 3px;
}
#button-bar button {
border: none;
background: none;
cursor: pointer;
color: var(--root-color);
}
#edit-button {
margin-left: -10px;
}
li code {
font-size: 80%;
color: #a5a4a4;
}
li.toc-header-1 {
margin-left: 0;
}
li.toc-header-2 {
margin-left: 2ch;
}
li.toc-header-3 {
margin-left: 4ch;
}
li.toc-header-4 {
margin-left: 6ch;
}

View File

@ -1,26 +0,0 @@
function processClick(e) {
const dataEl = e.target.closest("[data-ref]");
syscall(
"system.invokeFunction",
"index.navigateToMention",
dataEl.getAttribute("data-ref"),
).catch(console.error);
}
document.getElementById("link-ul").addEventListener("click", processClick);
document.getElementById("hide-button").addEventListener("click", () => {
syscall("system.invokeFunction", "index.toggleTOC").catch(console.error);
});
document.body.addEventListener("mouseenter", () => {
console.log("Refreshing on focus");
syscall("system.invokeFunction", "index.renderTOC").catch(
console.error,
);
});
document.getElementById("reload-button").addEventListener("click", () => {
syscall("system.invokeFunction", "index.renderTOC").catch(
console.error,
);
});

View File

@ -10,8 +10,6 @@ syntax:
- "$"
regex: "\\$[a-zA-Z\\.\\-\\/]+[\\w\\.\\-\\/]*"
className: sb-named-anchor
assets:
- asset/*
functions:
loadBuiltinsIntoIndex:
path: builtins.ts:loadBuiltinsIntoIndex
@ -159,20 +157,14 @@ functions:
# Mentions panel (postscript)
toggleMentions:
path: "./mentions_ps.ts:toggleMentions"
path: "./linked_mentions.ts:toggleMentions"
command:
name: "Mentions: Toggle"
key: ctrl-alt-m
updateMentions:
path: "./mentions_ps.ts:updateMentions"
env: client
events:
- editor:pageLoaded
navigateToMention:
path: "./mentions_ps.ts:navigate"
renderMentions:
path: "./mentions_ps.ts:renderMentions"
path: "./linked_mentions.ts:renderMentions"
panelWidget: bottom
# TOC
toggleTOC:
@ -184,8 +176,7 @@ functions:
renderTOC:
path: toc.ts:renderTOC
env: client
events:
- editor:pageLoaded
panelWidget: top
lintYAML:
path: lint.ts:lintYAML

View File

@ -0,0 +1,46 @@
import { clientStore, editor, system } from "$sb/silverbullet-syscall/mod.ts";
import { CodeWidgetContent } from "$sb/types.ts";
import { queryObjects } from "./api.ts";
import { LinkObject } from "./page_links.ts";
const hideMentionsKey = "hideMentions";
export async function toggleMentions() {
let hideMentions = await clientStore.get(hideMentionsKey);
hideMentions = !hideMentions;
await clientStore.set(hideMentionsKey, hideMentions);
if (!hideMentions) {
await renderMentions();
} else {
await editor.dispatch({});
}
}
export async function renderMentions(): Promise<CodeWidgetContent | null> {
const page = await editor.getCurrentPage();
const linksResult = await queryObjects<LinkObject>("link", {
// Query all links that point to this page, excluding those that are inside directives and self pointers.
filter: ["and", ["!=", ["attr", "page"], ["string", page]], ["and", ["=", [
"attr",
"toPage",
], ["string", page]], ["=", ["attr", "inDirective"], ["boolean", false]]]],
});
if (linksResult.length === 0) {
// Don't show the panel if there are no links here.
return null;
} else {
let renderedMd = "# Linked Mentions\n";
for (const link of linksResult) {
let snippet = await system.invokeFunction(
"markdown.markdownToHtml",
link.snippet,
);
// strip HTML tags
snippet = snippet.replace(/<[^>]*>?/gm, "");
renderedMd += `* [[${link.ref}]]: ...${snippet}...\n`;
}
return {
markdown: renderedMd,
};
}
}

View File

@ -1,85 +0,0 @@
import { asset } from "$sb/plugos-syscall/mod.ts";
import { clientStore, editor } from "$sb/silverbullet-syscall/mod.ts";
import { queryObjects } from "./api.ts";
import { LinkObject } from "./page_links.ts";
const hideMentionsKey = "hideMentions";
export async function toggleMentions() {
let hideMentions = await clientStore.get(hideMentionsKey);
hideMentions = !hideMentions;
await clientStore.set(hideMentionsKey, hideMentions);
if (!hideMentions) {
await renderMentions();
} else {
await editor.hidePanel("bottom");
}
}
// Triggered when switching pages or upon first load
export async function updateMentions() {
if (await clientStore.get(hideMentionsKey)) {
return;
}
await renderMentions();
}
// use internal navigation via syscall to prevent reloading the full page.
export async function navigate(ref: string) {
const currentPage = await editor.getCurrentPage();
const [page, pos] = ref.split(/[@$]/);
if (page === currentPage) {
await editor.moveCursor(+pos, true);
} else {
await editor.navigate(page, +pos);
}
}
function escapeHtml(unsafe: string) {
return unsafe.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(
/>/g,
"&gt;",
);
}
export async function renderMentions() {
const page = await editor.getCurrentPage();
const linksResult = await queryObjects<LinkObject>("link", {
// Query all links that point to this page, excluding those that are inside directives and self pointers.
filter: ["and", ["!=", ["attr", "page"], ["string", page]], ["and", ["=", [
"attr",
"toPage",
], ["string", page]], ["=", ["attr", "inDirective"], ["boolean", false]]]],
});
if (linksResult.length === 0) {
// Don't show the panel if there are no links here.
await editor.hidePanel("bottom");
} else {
const css = await asset.readAsset("asset/style.css");
const js = await asset.readAsset("asset/linked_mentions.js");
await editor.showPanel(
"bottom",
1,
` <style>${css}</style>
<div id="sb-main"><div id="sb-editor"><div class="cm-editor">
<div id="button-bar">
<button id="reload-button" title="Reload"><svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><polyline points="23 4 23 10 17 10"></polyline><polyline points="1 20 1 14 7 14"></polyline><path d="M3.51 9a9 9 0 0 1 14.85-3.36L23 10M1 14l4.64 4.36A9 9 0 0 0 20.49 15"></path></svg></button>
<button id="hide-button" title="Hide linked mentions"><svg viewBox="0 0 24 24" width="12" height="12" stroke="currentColor" stroke-width="2" fill="none" stroke-linecap="round" stroke-linejoin="round" class="css-i6dzq1"><path d="M17.94 17.94A10.07 10.07 0 0 1 12 20c-7 0-11-8-11-8a18.45 18.45 0 0 1 5.06-5.94M9.9 4.24A9.12 9.12 0 0 1 12 4c7 0 11 8 11 8a18.5 18.5 0 0 1-2.16 3.19m-6.72-1.07a3 3 0 1 1-4.24-4.24"></path><line x1="1" y1="1" x2="23" y2="23"></line></svg></button>
</div>
<div class="cm-line sb-line-h2">Linked Mentions</div>
<ul id="link-ul">
${
linksResult.map((link) =>
`<li data-ref="${link.ref}"><span class="sb-wiki-link-page">${link.ref}</span>: <code>...${
escapeHtml(link.snippet)
}...</code></li>`
).join("")
}
</ul>
</div></div></div>
`,
js,
);
}
}

View File

@ -5,7 +5,7 @@ import {
system,
} from "$sb/silverbullet-syscall/mod.ts";
import { renderToText, traverseTree, traverseTreeAsync } from "$sb/lib/tree.ts";
import { asset } from "$sb/syscalls.ts";
import { CodeWidgetContent } from "$sb/types.ts";
const hideTOCKey = "hideTOC";
const headerThreshold = 3;
@ -30,9 +30,11 @@ async function markdownToHtml(text: string): Promise<string> {
return system.invokeFunction("markdown.markdownToHtml", text);
}
export async function renderTOC(reload = false) {
export async function renderTOC(
reload = false,
): Promise<CodeWidgetContent | null> {
if (await clientStore.get(hideTOCKey)) {
return editor.hidePanel("top");
return null;
}
const page = await editor.getCurrentPage();
const text = await editor.getText();
@ -41,9 +43,7 @@ export async function renderTOC(reload = false) {
await traverseTreeAsync(tree, async (n) => {
if (n.type?.startsWith("ATXHeading")) {
headers.push({
name: await markdownToHtml(
n.children!.slice(1).map(renderToText).join("").trim(),
),
name: n.children!.slice(1).map(renderToText).join("").trim(),
pos: n.from!,
level: +n.type[n.type.length - 1],
});
@ -52,39 +52,19 @@ export async function renderTOC(reload = false) {
}
return false;
});
// console.log("All headers", headers);
if (!reload && cachedTOC === JSON.stringify(headers)) {
// TOC is the same, not updating
return;
}
cachedTOC = JSON.stringify(headers);
if (headers.length < headerThreshold) {
// console.log("Not enough headers, not showing TOC", headers.length);
await editor.hidePanel("top");
return;
console.log("Not enough headers, not showing TOC", headers.length);
return null;
}
const css = await asset.readAsset("asset/style.css");
const js = await asset.readAsset("asset/toc.js");
await editor.showPanel(
"top",
1,
` <style>${css}</style>
<div id="sb-main"><div id="sb-editor"><div class="cm-editor">
<div id="button-bar">
<button id="reload-button" title="Reload"><svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><polyline points="23 4 23 10 17 10"></polyline><polyline points="1 20 1 14 7 14"></polyline><path d="M3.51 9a9 9 0 0 1 14.85-3.36L23 10M1 14l4.64 4.36A9 9 0 0 0 20.49 15"></path></svg></button>
<button id="hide-button" title="Hide TOC"><svg viewBox="0 0 24 24" width="12" height="12" stroke="currentColor" stroke-width="2" fill="none" stroke-linecap="round" stroke-linejoin="round" class="css-i6dzq1"><path d="M17.94 17.94A10.07 10.07 0 0 1 12 20c-7 0-11-8-11-8a18.45 18.45 0 0 1 5.06-5.94M9.9 4.24A9.12 9.12 0 0 1 12 4c7 0 11 8 11 8a18.5 18.5 0 0 1-2.16 3.19m-6.72-1.07a3 3 0 1 1-4.24-4.24"></path><line x1="1" y1="1" x2="23" y2="23"></line></svg></button>
</div>
<div class="cm-line sb-line-h2">Table of Contents</div>
<ul id="link-ul">
${
headers.map((header) =>
`<li data-ref="${page}@${header.pos}" class="toc-header-${header.level}"><span class="sb-wiki-link-page">${header.name}</span></li>`
).join("")
}
</ul>
</div></div></div>
`,
js,
);
// console.log("Headers", headers);
const renderedMd = "# Table of Contents\n" +
headers.map((header) =>
`${
" ".repeat((header.level - 1) * 2)
}* [[${page}@${header.pos}|${header.name}]]`
).join("\n");
// console.log("Markdown", renderedMd);
return {
markdown: renderedMd,
};
}

View File

@ -41,6 +41,7 @@ import { clientCodeWidgetSyscalls } from "./syscalls/client_code_widget.ts";
import { KVPrimitivesManifestCache } from "../plugos/manifest_cache.ts";
import { deepObjectMerge } from "$sb/lib/json.ts";
import { Query } from "$sb/types.ts";
import { PanelWidgetHook } from "./hooks/panel_widget.ts";
const plugNameExtractRegex = /\/(.+)\.plug\.js$/;
@ -51,6 +52,7 @@ export class ClientSystem {
codeWidgetHook: CodeWidgetHook;
mdExtensions: MDExt[] = [];
system: System<SilverBulletHooks>;
panelWidgetHook: PanelWidgetHook;
constructor(
private client: Client,
@ -83,6 +85,10 @@ export class ClientSystem {
this.codeWidgetHook = new CodeWidgetHook();
this.system.addHook(this.codeWidgetHook);
// Panel widget hook
this.panelWidgetHook = new PanelWidgetHook();
this.system.addHook(this.panelWidgetHook);
// MQ hook
if (client.syncMode) {
// Process MQ messages locally

View File

@ -70,10 +70,10 @@ export function fencedCodePlugin(editor: Client) {
const widget = renderMode === "markdown"
? new MarkdownWidget(
from + lineStrings[0].length + 1,
to - lineStrings[lineStrings.length - 1].length - 1,
editor,
lineStrings.slice(1, lineStrings.length - 1).join("\n"),
codeWidgetCallback,
"sb-markdown-widget",
)
: new IFrameWidget(
from + lineStrings[0].length + 1,

View File

@ -11,21 +11,25 @@ export class MarkdownWidget extends WidgetType {
renderedMarkdown?: string;
constructor(
readonly from: number,
readonly to: number,
readonly from: number | undefined,
readonly client: Client,
readonly bodyText: string,
readonly codeWidgetCallback: CodeWidgetCallback,
readonly className: string,
) {
super();
}
toDOM(): HTMLElement {
const div = document.createElement("div");
div.className = "sb-markdown-widget";
div.className = this.className;
const cacheItem = this.client.getWidgetCache(this.bodyText);
if (cacheItem) {
div.innerHTML = this.wrapHtml(cacheItem.html);
div.innerHTML = this.wrapHtml(
cacheItem.html,
this.from !== undefined,
this.from !== undefined,
);
this.attachListeners(div);
}
@ -43,6 +47,11 @@ export class MarkdownWidget extends WidgetType {
this.bodyText,
this.client.currentPage!,
);
if (!widgetContent) {
div.innerHTML = "";
// div.style.display = "none";
return;
}
const lang = buildMarkdown(this.client.system.mdExtensions);
let mdTree = parse(
lang,
@ -80,7 +89,11 @@ export class MarkdownWidget extends WidgetType {
// HTML still same as in cache, no need to re-render
return;
}
div.innerHTML = this.wrapHtml(html);
div.innerHTML = this.wrapHtml(
html,
this.from !== undefined,
this.from !== undefined,
);
this.attachListeners(div);
// Let's give it a tick, then measure and cache
@ -93,12 +106,20 @@ export class MarkdownWidget extends WidgetType {
});
}
private wrapHtml(html: string) {
private wrapHtml(html: string, editButton = true, sourceButton = true) {
return `
<div class="button-bar">
<button class="source-button" title="Show Markdown source"><svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="feather feather-code"><polyline points="16 18 22 12 16 6"></polyline><polyline points="8 6 2 12 8 18"></polyline></svg></button>
${
sourceButton
? `<button class="source-button" title="Show Markdown source"><svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="feather feather-code"><polyline points="16 18 22 12 16 6"></polyline><polyline points="8 6 2 12 8 18"></polyline></svg></button>`
: ""
}
<button class="reload-button" title="Reload"><svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><polyline points="23 4 23 10 17 10"></polyline><polyline points="1 20 1 14 7 14"></polyline><path d="M3.51 9a9 9 0 0 1 14.85-3.36L23 10M1 14l4.64 4.36A9 9 0 0 0 20.49 15"></path></svg></button>
<button class="edit-button" title="Edit"><svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="feather feather-edit"><path d="M11 4H4a2 2 0 0 0-2 2v14a2 2 0 0 0 2 2h14a2 2 0 0 0 2-2v-7"></path><path d="M18.5 2.5a2.121 2.121 0 0 1 3 3L12 15l-4 1 1-4 9.5-9.5z"></path></svg></button>
${
editButton
? `<button class="edit-button" title="Edit"><svg xmlns="http://www.w3.org/2000/svg" width="12" height="12" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="feather feather-edit"><path d="M11 4H4a2 2 0 0 0-2 2v14a2 2 0 0 0 2 2h14a2 2 0 0 0 2-2v-7"></path><path d="M18.5 2.5a2.121 2.121 0 0 1 3 3L12 15l-4 1 1-4 9.5-9.5z"></path></svg></button>`
: ""
}
</div>
${html}`;
}
@ -109,7 +130,12 @@ export class MarkdownWidget extends WidgetType {
// Override default click behavior with a local navigate (faster)
el.addEventListener("click", (e) => {
e.preventDefault();
this.client.navigate(el.dataset.ref!);
const [pageName, pos] = el.dataset.ref!.split(/[$@]/);
if (pos && pos.match(/^\d+$/)) {
this.client.navigate(pageName, +pos);
} else {
this.client.navigate(pageName, pos);
}
});
});
@ -134,18 +160,20 @@ export class MarkdownWidget extends WidgetType {
);
});
div.querySelector(".edit-button")!.addEventListener("click", () => {
this.client.editorView.dispatch({
selection: { anchor: this.from },
if (this.from !== undefined) {
div.querySelector(".edit-button")!.addEventListener("click", () => {
this.client.editorView.dispatch({
selection: { anchor: this.from! },
});
this.client.focus();
});
this.client.focus();
});
div.querySelector(".source-button")!.addEventListener("click", () => {
div.innerText = this.renderedMarkdown!;
});
}
div.querySelector(".reload-button")!.addEventListener("click", () => {
this.renderContent(div, undefined).catch(console.error);
});
div.querySelector(".source-button")!.addEventListener("click", () => {
div.innerText = this.renderedMarkdown!;
});
}
get estimatedHeight(): number {

View File

@ -1,67 +1,40 @@
import { Decoration, EditorState, WidgetType } from "../deps.ts";
import type { Client } from "../client.ts";
import { decoratorStateField } from "./util.ts";
import { PanelConfig } from "../types.ts";
import { createWidgetSandboxIFrame } from "../components/widget_sandbox_iframe.ts";
import { MarkdownWidget } from "./markdown_widget.ts";
class IFrameWidget extends WidgetType {
widgetHeightCacheKey: string;
constructor(
readonly editor: Client,
readonly panel: PanelConfig,
readonly className: string,
) {
super();
this.widgetHeightCacheKey = `${this.editor.currentPage!}#${this.className}`;
}
toDOM(): HTMLElement {
const iframe = createWidgetSandboxIFrame(
this.editor,
this.widgetHeightCacheKey,
this.panel,
);
iframe.classList.add(this.className);
return iframe;
}
get estimatedHeight(): number {
return this.editor.space.getCachedWidgetHeight(
this.widgetHeightCacheKey,
);
}
eq(other: WidgetType): boolean {
return this.panel.html ===
(other as IFrameWidget).panel.html &&
this.panel.script ===
(other as IFrameWidget).panel.script;
}
}
export function postScriptPrefacePlugin(editor: Client) {
export function postScriptPrefacePlugin(
editor: Client,
) {
const panelWidgetHook = editor.system.panelWidgetHook;
return decoratorStateField((state: EditorState) => {
const widgets: any[] = [];
if (editor.ui.viewState.panels.top.html) {
const topCallback = panelWidgetHook.callbacks.get("top");
if (topCallback) {
widgets.push(
Decoration.widget({
widget: new IFrameWidget(
widget: new MarkdownWidget(
undefined,
editor,
editor.ui.viewState.panels.top,
"sb-top-iframe",
`top:${editor.currentPage}`,
topCallback,
"sb-markdown-top-widget",
),
side: -1,
block: true,
}).range(0),
);
}
if (editor.ui.viewState.panels.bottom.html) {
const bottomCallback = panelWidgetHook.callbacks.get("bottom");
if (bottomCallback) {
widgets.push(
Decoration.widget({
widget: new IFrameWidget(
widget: new MarkdownWidget(
undefined,
editor,
editor.ui.viewState.panels.bottom,
"sb-bottom-iframe",
`bottom:${editor.currentPage}`,
bottomCallback,
"sb-markdown-bottom-widget",
),
side: 1,
block: true,

59
web/hooks/panel_widget.ts Normal file
View File

@ -0,0 +1,59 @@
import { Hook, Manifest } from "../../plugos/types.ts";
import { System } from "../../plugos/system.ts";
import { CodeWidgetCallback } from "$sb/types.ts";
export type PanelWidgetT = {
panelWidget?: "top" | "bottom";
};
export class PanelWidgetHook implements Hook<PanelWidgetT> {
callbacks = new Map<string, CodeWidgetCallback>();
constructor() {
}
collectAllPanelWidgets(system: System<PanelWidgetT>) {
this.callbacks.clear();
for (const plug of system.loadedPlugs.values()) {
for (
const [name, functionDef] of Object.entries(
plug.manifest!.functions,
)
) {
if (!functionDef.panelWidget) {
continue;
}
this.callbacks.set(
functionDef.panelWidget,
(bodyText, pageName) => {
return plug.invoke(name, [bodyText, pageName]);
},
);
}
}
}
apply(system: System<PanelWidgetT>): void {
this.collectAllPanelWidgets(system);
system.on({
plugLoaded: () => {
this.collectAllPanelWidgets(system);
},
});
}
validateManifest(manifest: Manifest<PanelWidgetT>): string[] {
const errors = [];
for (const functionDef of Object.values(manifest.functions)) {
if (!functionDef.panelWidget) {
continue;
}
if (!["top", "bottom"].includes(functionDef.panelWidget)) {
errors.push(
`Panel widgets must be attached to either 'top' or 'bottom'.`,
);
}
}
return errors;
}
}

View File

@ -444,8 +444,31 @@
}
.sb-markdown-widget {
overflow-y: scroll;
margin: 0 0 -4ch 0;
}
.sb-markdown-top-widget h1,
.sb-markdown-bottom-widget h1 {
border-top-right-radius: 5px;
border-top-left-radius: 5px;
margin: 0;
padding: 10px !important;
background-color: var(--editor-directive-background-color);
font-size: 1.2em;
}
.sb-markdown-top-widget {
margin-bottom: 10px;
}
.sb-markdown-bottom-widget {
margin-top: 10px;
}
.sb-markdown-widget,
.sb-markdown-top-widget:has(*),
.sb-markdown-bottom-widget:has(*) {
overflow-y: scroll;
border: 1px solid var(--editor-directive-background-color);
border-radius: 5px;
white-space: nowrap;

View File

@ -98,8 +98,6 @@ export const initialViewState: AppViewState = {
rhs: {},
bhs: {},
modal: {},
top: {},
bottom: {},
},
allPages: [],
commands: new Map(),