From 41a311d62561928701fb1abcb602e6edbe6cc92e Mon Sep 17 00:00:00 2001 From: Zef Hemel Date: Mon, 27 Feb 2023 15:55:31 +0100 Subject: [PATCH] Remove up/down movement support between page name and content --- web/components/top_bar.tsx | 16 ---------------- web/editor.tsx | 18 ------------------ 2 files changed, 34 deletions(-) diff --git a/web/components/top_bar.tsx b/web/components/top_bar.tsx index bf695bd..9631600 100644 --- a/web/components/top_bar.tsx +++ b/web/components/top_bar.tsx @@ -93,22 +93,6 @@ export function TopBar({ return onRename(); } }} - onKeyUp={(view, event) => { - // When moving cursor down, cancel and move back to editor - if (event.key === "ArrowDown") { - const parent = - (event.target as any).parentElement.parentElement; - // Unless we have autocomplete open - if ( - parent.getElementsByClassName("cm-tooltip-autocomplete") - .length === 0 - ) { - onRename(); - return true; - } - } - return false; - }} completer={completer} onEnter={(newName) => { onRename(newName); diff --git a/web/editor.tsx b/web/editor.tsx index 92cfba1..2cdffed 100644 --- a/web/editor.tsx +++ b/web/editor.tsx @@ -691,23 +691,6 @@ export class Editor { { selector: "FrontMatter", class: "sb-frontmatter" }, ]), keymap.of([ - { - key: "ArrowUp", - run: (view): boolean => { - // When going up while at the top of the document, focus the page name - const selection = view.state.selection.main; - const line = view.state.doc.lineAt(selection.from); - // Are we at the top of the document? - if (line.number === 1) { - // This can be done much nicer, but this is shorter, so... :) - document.querySelector( - "#sb-current-page .cm-content", - )!.focus(); - return true; - } - return false; - }, - }, ...smartQuoteKeymap, ...closeBracketsKeymap, ...standardKeymap, @@ -786,7 +769,6 @@ export class Editor { } }, click: (event: MouseEvent, view: EditorView) => { - console.log("Click handler") safeRun(async () => { const clickEvent: ClickEvent = { page: pageName,