neil/silverbullet
1
0
Fork 0
Code

Restrict valid page names

Browse Source
This commit is contained in:
Zef Hemel 2023-07-07 11:44:05 +02:00
parent 59ff0643b0
commit 04d6de18e6
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plug-api/lib/page.ts
View File

@ -1,4 +1,4 @@
export function isValidPageName(name: string): boolean {
// Page can not be empty and not end with a file extension (e.g. "bla.md")
return name !== "" && !/\.[a-zA-Z]+$/.test(name);
return name !== "" && !name.startsWith(".") && !/\.[a-zA-Z]+$/.test(name);
}

2
plugs/core/page.ts
View File

@ -139,7 +139,7 @@ export async function renamePage(cmdDef: any) {
if (!isValidPageName(newName)) {
return editor.flashNotification(
"Invalid page name: page names cannot end with a file extension",
"Invalid page name: page names cannot end with a file extension nor start with a '.'",
"error",
);
}

4
plugs/markdown/markdown_render.ts
View File

@ -394,8 +394,8 @@ export function renderMarkdownToHtml(
t.attrs!.src = options.translateUrls!(t.attrs!.src!);
}
if (t.name === "a") {
t.attrs!.href = options.translateUrls!(t.attrs!.href!);
if (t.name === "a" && t.attrs!.href) {
t.attrs!.href = options.translateUrls!(t.attrs!.href);
}
});
}

2
web/editor.tsx
View File

@ -1167,7 +1167,7 @@ export class Editor {
if (!isValidPageName(name)) {
return this.flashNotification(
"Invalid page name: page names cannot end with a file extension",
"Invalid page name: page names cannot end with a file extension nor start with a '.'",
"error",
);
}