neil/silverbullet
1
0
Fork 0
Code

Fixes #204

Browse Source
This commit is contained in:
Zef Hemel 2022-12-16 13:00:06 +01:00
parent 74c4694af6
commit 0314e3025f
4 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Dockerfile
View File

@ -23,4 +23,4 @@ EXPOSE 3000
# Run the server, allowing to pass in additional argument at run time, e.g.
# docker run -p 3002:3000 -v myspace:/space -it zefhemel/silverbullet --user me:letmein
ENTRYPOINT ["/tini", "--", "deno", "run", "-A", "--unstable", "/silverbullet.js", "/space"]
ENTRYPOINT ["/tini", "--", "deno", "run", "-A", "--unstable", "/silverbullet.js", "--hostname", "0.0.0.0", "/space"]

15
cmd/server.ts
View File

@ -5,17 +5,20 @@ import { AssetBundle, AssetJson } from "../plugos/asset_bundle/bundle.ts";
export function serveCommand(options: any, folder: string) {
const pagesPath = path.resolve(Deno.cwd(), folder);
const hostname = options.hostname || "0.0.0.0";
const hostname = options.hostname || "127.0.0.1";
const port = options.port || 3000;
console.log(
"Going to start Silver Bullet on",
"Going to start Silver Bullet binding to",
`${hostname}:${port}`,
"serving pages from",
pagesPath,
"with db file",
options.db,
);
console.log("Serving pages from", pagesPath);
if (hostname === "127.0.0.1") {
console.log(
`_Note:_ Silver Bullet will only be available locally (via http://localhost:${port}), to allow outside connections, pass --host 0.0.0.0 as a flag.`,
);
}
const httpServer = new HttpServer({
hostname,

1
website/CHANGELOG.md
View File

@ -5,6 +5,7 @@ release.
## Next
* Vim mode is here! This mode can be enabled on a per-client basis (its state is stored in the browser). To toggle Vim mode on or off use the {[Editor: Toggle Vim Mode]} command.
* Security update: SB now binds to `127.0.0.1` by default, allowing just connections via `localhost`. To allow outside connections, pass the `--hostname 0.0.0.0` flag (and ideally combine it with a `--user username:password` flag to add basic authentication).
---

6
website/Silver Bullet.md
View File

@ -106,9 +106,11 @@ To run Silver Bullet, create a folder for your pages (it can be empty, or be an
silverbullet <pages-path>
```
By default, Silver Bullet will bind to port `3000`, to use a different port use the `--port` flag. By default Silver Bullet is unauthenticated, to password-protect it, specify a username and password with the `--user` flag (e.g. `--user pete:mypassword`).
By default, Silver Bullet will bind to port `3000`, to use a different port use the `--port` flag.
Once downloaded and booted, Silver Bullet will print out a URL to open SB in your browser (by default this will be http://localhost:3000 ).
For security reasons, by default Silver Bullet only allows connections via `localhost` (or `127.0.0.1`). To also allow connections from the network, pass a `--hostname 0.0.0.0` flag, ideally combined with `--user username:password` to add BasicAuth password protection.
Once downloaded and booted, Silver Bullet will print out a URL to open SB in your browser.
## Upgrading Silver Bullet
Silver Bullet is regularly updated. To get the latest and greatest, simply run: