From 77df78c1affd305a10355329a84c32383fe4896a Mon Sep 17 00:00:00 2001 From: "Berk D. Demir" Date: Wed, 9 Jul 2025 22:09:37 -0700 Subject: [PATCH] Fix compiler warnings: Unused function params We could use C23's `[[maybe_unused]]` but MSVC doesn't support it. So we void cast them with an accompanying "unused" comment. --- lib/blisp.c | 4 +++- lib/chip/blisp_chip_bl60x.c | 2 ++ lib/chip/blisp_chip_bl70x.c | 2 ++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/blisp.c b/lib/blisp.c index b3d8f42..58f0ff2 100644 --- a/lib/blisp.c +++ b/lib/blisp.c @@ -16,6 +16,8 @@ static void drain(struct sp_port* port) { #if defined(__APPLE__) || defined(__FreeBSD__) sp_drain(port); +#else + (void)port; // unused #endif } @@ -414,4 +416,4 @@ blisp_return_t blisp_device_reset(struct blisp_device* device) { void blisp_device_close(struct blisp_device* device) { struct sp_port* serial_port = device->serial_port; sp_close(serial_port); -} \ No newline at end of file +} diff --git a/lib/chip/blisp_chip_bl60x.c b/lib/chip/blisp_chip_bl60x.c index e8ae033..8639390 100644 --- a/lib/chip/blisp_chip_bl60x.c +++ b/lib/chip/blisp_chip_bl60x.c @@ -6,6 +6,8 @@ int64_t blisp_chip_bl60x_get_eflash_loader(uint8_t clk_type, uint8_t** firmware_buf_ptr) { + (void)clk_type; // unused + uint8_t* firmware_buf = malloc(sizeof(bl60x_eflash_loader_bin)); memcpy(firmware_buf, bl60x_eflash_loader_bin, sizeof(bl60x_eflash_loader_bin)); *(firmware_buf + 0xE0) = 4; // TODO: 40 MHz clock diff --git a/lib/chip/blisp_chip_bl70x.c b/lib/chip/blisp_chip_bl70x.c index a380720..0b7360f 100644 --- a/lib/chip/blisp_chip_bl70x.c +++ b/lib/chip/blisp_chip_bl70x.c @@ -6,6 +6,8 @@ int64_t blisp_chip_bl70x_get_eflash_loader(uint8_t clk_type, uint8_t** firmware_buf_ptr) { + (void) clk_type; // ununsed + uint8_t* firmware_buf = malloc(sizeof(bl70x_eflash_loader_bin)); memcpy(firmware_buf, bl70x_eflash_loader_bin, sizeof(bl70x_eflash_loader_bin)); *(firmware_buf + 0xE0) = 1; // TODO: 32 MHz clock