From 56e077d2e566f84ade9224ab9b85cbce88a943b8 Mon Sep 17 00:00:00 2001
From: Michael Woods <michael.woods@highlyrefined.com>
Date: Mon, 28 Dec 2020 14:21:09 -0500
Subject: [PATCH] try bool values instead of string for binary_sensor

---
 src/mqtt.js       |  4 ++--
 test/mqtt.spec.js | 14 +++++++-------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/mqtt.js b/src/mqtt.js
index b93a075..eab21be 100644
--- a/src/mqtt.js
+++ b/src/mqtt.js
@@ -149,8 +149,8 @@ class MQTT {
             availability_topic: this.getAvailabilityTopic(),
             payload_available: 'true',
             payload_not_available: 'false',
-            payload_on: 'true',
-            payload_off: 'false',
+            payload_on: true,
+            payload_off: false,
             state_topic: this.getStateTopic(diag),
             unit_of_measurement: diagEl.unit,
             value_template: `{{ value_json.${MQTT.convertName(diagEl.name)} }}`,
diff --git a/test/mqtt.spec.js b/test/mqtt.spec.js
index b9f8fdd..ab9aa66 100644
--- a/test/mqtt.spec.js
+++ b/test/mqtt.spec.js
@@ -37,7 +37,7 @@ describe('MQTT', () => {
                 assert.strictEqual(mqtt.getConfigTopic(d), 'homeassistant/sensor/XXX/ambient_air_temperature/config');
             });
             it('should generate state topics', () => {
-                assert.strictEqual(mqtt.getStateTopic(d, d.diagnosticElements[0]), 'homeassistant/sensor/XXX/ambient_air_temperature/state');
+                assert.strictEqual(mqtt.getStateTopic(d), 'homeassistant/sensor/XXX/ambient_air_temperature/state');
             });
         });
 
@@ -72,8 +72,8 @@ describe('MQTT', () => {
                     name: 'Ambient Air Temperature',
                     payload_available: 'true',
                     payload_not_available: 'false',
-                    payload_off: 'false',
-                    payload_on: 'true',
+                    payload_off: false,
+                    payload_on: true,
                     state_topic: 'homeassistant/sensor/XXX/ambient_air_temperature/state',
                     unit_of_measurement: '°C',
                     value_template: '{{ value_json.ambient_air_temperature }}'
@@ -104,8 +104,8 @@ describe('MQTT', () => {
                     name: 'Priority Charge Indicator',
                     payload_available: 'true',
                     payload_not_available: 'false',
-                    payload_off: 'false',
-                    payload_on: 'true',
+                    payload_off: false,
+                    payload_on: true,
                     state_topic: 'homeassistant/binary_sensor/XXX/ev_charge_state/state',
                     unit_of_measurement: undefined,
                     value_template: '{{ value_json.priority_charge_indicator }}'
@@ -138,8 +138,8 @@ describe('MQTT', () => {
                     name: 'Tire Pressure: Left Front',
                     payload_available: 'true',
                     payload_not_available: 'false',
-                    payload_off: 'false',
-                    payload_on: 'true',
+                    payload_off: false,
+                    payload_on: true,
                     state_topic: 'homeassistant/sensor/XXX/tire_pressure/state',
                     unit_of_measurement: 'kPa',
                     value_template: '{{ value_json.tire_pressure_lf }}'